Martin Diehl
|
4d62432d34
|
internal functions at the end
|
2020-03-16 08:22:36 +01:00 |
|
Martin Diehl
|
ef4b24646d
|
only store parameters that are needed during the simulation
|
2020-03-16 08:16:55 +01:00 |
|
Martin Diehl
|
23c6510faa
|
atol=0.0 is fine
crystallite takes max(atol, rtol*X), so atol=0.0 means that convergence
is based on rtol only
|
2020-03-16 00:52:18 +01:00 |
|
Martin Diehl
|
e3bbd32b1e
|
polishing
|
2020-03-16 00:12:18 +01:00 |
|
Martin Diehl
|
0735d2da7c
|
no need to store # sytems/family
|
2020-03-16 00:05:51 +01:00 |
|
Martin Diehl
|
c7f3c2cb56
|
notation from DAMASK paper
|
2020-03-15 21:58:28 +01:00 |
|
Martin Diehl
|
e53ba801fa
|
more systematic file structure
|
2020-03-15 17:04:28 +01:00 |
|
Martin Diehl
|
d37f42da4f
|
better sort files according to solver
|
2020-03-15 16:58:30 +01:00 |
|
Martin Diehl
|
5b71f1050f
|
better make internal function
- not used
- no check whether matrix is positive-definite, i.e. danger of NaN
|
2020-03-15 16:11:28 +01:00 |
|
Martin Diehl
|
8c78347a8b
|
equivalent, but systematic better visible
|
2020-03-15 16:05:56 +01:00 |
|
Martin Diehl
|
7677bc876b
|
more precise documentation
symmetric is not enough, could result in taking the square root of negative eigenvalues
|
2020-03-15 15:58:25 +01:00 |
|
Martin Diehl
|
253ee0013d
|
equivalent, but more systematic
|
2020-03-15 15:03:53 +01:00 |
|
Martin Diehl
|
65decfc48a
|
intention more clear
|
2020-03-15 14:54:25 +01:00 |
|
Martin Diehl
|
66302fa6da
|
rotational part is always of 3x3 tensor
|
2020-03-15 14:21:11 +01:00 |
|
Martin Diehl
|
4b3f4834b5
|
unified documentation and variable names
|
2020-03-15 14:07:38 +01:00 |
|
Martin Diehl
|
2d678fae8f
|
better readable
|
2020-03-15 13:52:50 +01:00 |
|
Martin Diehl
|
6a0d4678a9
|
better readable
|
2020-03-15 13:19:07 +01:00 |
|
Martin Diehl
|
9aa9b7ff69
|
documenting parameters
|
2020-03-15 13:09:27 +01:00 |
|
Martin Diehl
|
ae49e6710d
|
documenting for doxygen
|
2020-03-15 12:54:35 +01:00 |
|
Martin Diehl
|
8cc16da53f
|
atol is part of the state structure, no need for suffix
|
2020-03-15 09:51:40 +01:00 |
|
Martin Diehl
|
7ec5a0bd6b
|
make consistency check
|
2020-03-15 09:39:35 +01:00 |
|
Martin Diehl
|
a3e2d39854
|
no need to store atol twice
|
2020-03-15 08:47:16 +01:00 |
|
Martin Diehl
|
9ad391ae50
|
include sanity check
|
2020-03-14 22:53:05 +01:00 |
|
Martin Diehl
|
38b755740b
|
no need to store atol
|
2020-03-14 20:55:46 +01:00 |
|
Martin Diehl
|
eb08f9f0b2
|
polishing
|
2020-03-14 19:40:05 +01:00 |
|
Martin Diehl
|
33aaa94865
|
use centralized (and tested) funtionality
|
2020-03-14 17:29:08 +01:00 |
|
Martin Diehl
|
8bd708f3b1
|
correct type
|
2020-03-14 13:53:21 +01:00 |
|
Martin Diehl
|
5c4ddf5138
|
Merge branch 'development' into MiscImprovements
|
2020-03-14 12:52:30 +01:00 |
|
Martin Diehl
|
07ecf60722
|
more explicit and flexible
|
2020-03-13 14:03:04 +01:00 |
|
Martin Diehl
|
e8b5a6dfe4
|
bugfix:
full stress tensor should be used
|
2020-03-10 14:02:09 +01:00 |
|
Martin Diehl
|
705ee908a2
|
Merge remote-tracking branch 'origin/development' into clean-and-polish-damage
|
2020-03-10 13:49:11 +01:00 |
|
Martin Diehl
|
aa75591ea9
|
no need to prefix internal parameters
also, use CAPITALS for parameters, but not for module prefixes (does not
work for IO and HDF5 anyway)
|
2020-03-10 13:45:00 +01:00 |
|
Martin Diehl
|
2f16c1cacf
|
more relevant test
restricting to reasonable F allows to use a reasonable tolerance
|
2020-03-10 07:58:03 +01:00 |
|
Martin Diehl
|
39b2f8d2d9
|
clearer name
|
2020-03-10 06:13:54 +01:00 |
|
Martin Diehl
|
3fadbaa369
|
fixed typo
|
2020-03-09 22:20:33 +01:00 |
|
Martin Diehl
|
6bc57d4911
|
mainly code duplication and not used
|
2020-03-09 14:17:41 +01:00 |
|
Martin Diehl
|
4a93f2206d
|
avoid early return + use numpy names
|
2020-03-09 14:17:05 +01:00 |
|
Martin Diehl
|
105853004a
|
correct type conversions
|
2020-03-09 14:07:31 +01:00 |
|
Martin Diehl
|
a1f36b14d3
|
simplifying
still trying to figure out how to best use HDF5 for reference stiffness
|
2020-03-09 14:05:49 +01:00 |
|
Martin Diehl
|
cf8e3fb91a
|
single source of truth
|
2020-03-09 14:00:58 +01:00 |
|
Martin Diehl
|
a0f1509045
|
full out of source build
no temporary variables appear in src if following cmake procedure
|
2020-03-09 13:55:28 +01:00 |
|
Sharan Roongta
|
0b340a6d42
|
Merge branch 'less-public-variables' into development
|
2020-03-09 11:25:35 +01:00 |
|
Martin Diehl
|
9f8fbaa9f7
|
same names for same variables
|
2020-03-02 15:49:14 +01:00 |
|
Martin Diehl
|
c4a0bf62f0
|
UTF signs for clearer documentation
|
2020-03-02 15:30:39 +01:00 |
|
Martin Diehl
|
6701af6425
|
better readable, tested, and following standard notation
|
2020-03-01 23:00:06 +01:00 |
|
Martin Diehl
|
44f09099ca
|
sliprate is allready positive here
|
2020-03-01 18:48:47 +01:00 |
|
Martin Diehl
|
c5b07bc535
|
need to be defined
|
2020-03-01 10:22:37 +01:00 |
|
Martin Diehl
|
6dfc48f89e
|
better use names known from numpy
|
2020-03-01 09:52:46 +01:00 |
|
Martin Diehl
|
4ab3bfe96d
|
polishing/simplifying
|
2020-03-01 09:41:42 +01:00 |
|
Martin Diehl
|
37dd59193e
|
better readable
|
2020-03-01 09:34:33 +01:00 |
|
Martin Diehl
|
9e80d98709
|
no need to re-calculate projection over and over again
|
2020-03-01 09:06:03 +01:00 |
|
Martin Diehl
|
9b1823f879
|
should be checked for both ductile models
|
2020-03-01 08:28:21 +01:00 |
|
Martin Diehl
|
4b791a38a5
|
no need for a module variable
|
2020-02-29 17:19:34 +01:00 |
|
Martin Diehl
|
00d6187325
|
public functions first
|
2020-02-29 17:04:29 +01:00 |
|
Martin Diehl
|
0c70eefb91
|
always assume indicators of length 3
|
2020-02-29 17:03:01 +01:00 |
|
Martin Diehl
|
18ccc49d6f
|
avoid duplicated public/private statements
variables should be private
|
2020-02-29 15:15:41 +01:00 |
|
Martin Diehl
|
4d227fab2b
|
polishing
|
2020-02-29 14:34:19 +01:00 |
|
Martin Diehl
|
3713810592
|
simplified allocation for same shape
|
2020-02-29 13:53:04 +01:00 |
|
Martin Diehl
|
bcccf06450
|
Merge remote-tracking branch 'origin/development' into less-public-variables
|
2020-02-29 13:18:02 +01:00 |
|
Martin Diehl
|
4935f90d5a
|
polishing
|
2020-02-29 13:17:33 +01:00 |
|
Martin Diehl
|
2bc36121b2
|
less public variables, clearer names
|
2020-02-29 12:57:19 +01:00 |
|
Martin Diehl
|
ca76014e45
|
preparing removal of public functions
|
2020-02-29 12:21:03 +01:00 |
|
Martin Diehl
|
13e2b0725a
|
useful as external function
|
2020-02-29 12:20:40 +01:00 |
|
Martin Diehl
|
8700d7784c
|
avoid global variables
|
2020-02-29 11:10:23 +01:00 |
|
Martin Diehl
|
54881a6ca9
|
better readable: show that there is no division by zero
|
2020-02-29 10:55:52 +01:00 |
|
Martin Diehl
|
791db82136
|
better readable
|
2020-02-29 10:27:22 +01:00 |
|
Martin Diehl
|
8dd62f1c1e
|
better readable and with sanity checks
|
2020-02-29 10:20:38 +01:00 |
|
Martin Diehl
|
a9572f81a1
|
bugfix: array access out of bounds
this now uses always the first (source) entry of a particular type.
Needs clearer structure in the future
|
2020-02-29 09:52:33 +01:00 |
|
Martin Diehl
|
07ab7a4d57
|
one loop is enough
|
2020-02-29 09:36:42 +01:00 |
|
Martin Diehl
|
2429eee079
|
no need for 2 variables
|
2020-02-29 08:03:06 +01:00 |
|
Martin Diehl
|
0679fa1713
|
polishing
|
2020-02-29 07:58:33 +01:00 |
|
Martin Diehl
|
ba9bd9120e
|
unifying code style
|
2020-02-29 07:42:59 +01:00 |
|
Martin Diehl
|
53bd9f9b64
|
need to read in variable before it is used
|
2020-02-29 06:39:16 +01:00 |
|
Martin Diehl
|
5350f3950f
|
no need to store temporary variables
|
2020-02-29 06:38:08 +01:00 |
|
Martin Diehl
|
2b855940f5
|
not needed here
|
2020-02-28 21:54:32 +01:00 |
|
Martin Diehl
|
e4fe152810
|
no public parameters
|
2020-02-28 21:44:40 +01:00 |
|
Martin Diehl
|
3aec4f91f4
|
WIP: get rid of global variables from lattice
|
2020-02-28 19:46:18 +01:00 |
|
Martin Diehl
|
0fbba60c91
|
do not rely on public variables
|
2020-02-28 19:35:53 +01:00 |
|
Martin Diehl
|
15712d7ebb
|
last remaining outputID enums removed
|
2020-02-28 11:06:21 +01:00 |
|
Martin Diehl
|
11d456bcd7
|
no need for enums
no performance difference measurable but less complicated code without
them
|
2020-02-28 10:58:11 +01:00 |
|
Martin Diehl
|
991d0fe020
|
polishing/unifying
|
2020-02-28 10:40:17 +01:00 |
|
Martin Diehl
|
cf0f5f0fee
|
polishing
|
2020-02-28 10:04:38 +01:00 |
|
Martin Diehl
|
4c17963cd6
|
cleavage systems should reflect lattice symmetry
also {100} cleavage planes need investigation
|
2020-02-26 19:11:33 +01:00 |
|
Martin Diehl
|
c9b9c9103b
|
2 space indentation
|
2020-02-26 18:49:20 +01:00 |
|
Martin Diehl
|
73491f3be9
|
simplified and unified style
|
2020-02-26 18:37:17 +01:00 |
|
Martin Diehl
|
7e30c10e82
|
internal functions need no prefix and are located at the end
|
2020-02-26 18:02:47 +01:00 |
|
Martin Diehl
|
33dc44e512
|
2 space indentation
|
2020-02-26 17:55:19 +01:00 |
|
Martin Diehl
|
eacf0cc894
|
does not makes sense to have cleavage planes for isotropic
behavior can be recovered by using 'real' crystal structures and
suitable parameter (easiest for fcc/bcc)
|
2020-02-26 17:50:29 +01:00 |
|
Martin Diehl
|
1d77af66c0
|
preparing removal of initializeStructure
|
2020-02-26 07:23:29 +01:00 |
|
Martin Diehl
|
839443bc85
|
better (generic) name where possible
|
2020-02-26 07:06:25 +01:00 |
|
Martin Diehl
|
cbcb7dca5d
|
cleaning
|
2020-02-26 06:12:45 +01:00 |
|
Martin Diehl
|
82dee9db0e
|
matching names
|
2020-02-25 17:53:15 +01:00 |
|
Martin Diehl
|
48604292e2
|
Merge remote-tracking branch 'origin/development' into MiscImprovements
|
2020-02-25 17:33:39 +01:00 |
|
Martin Diehl
|
4889e75e52
|
clearer structure
|
2020-02-25 17:32:49 +01:00 |
|
Martin Diehl
|
2c952c3410
|
these variables can be at leat write protected
|
2020-02-25 09:50:21 +01:00 |
|
Martin Diehl
|
7d7eff0d94
|
crystallite should be responsible of crystallite variables
|
2020-02-25 09:42:07 +01:00 |
|
Sharan Roongta
|
a2e8e5b13b
|
Merge branch 'simple-output-handling' into development
|
2020-02-23 19:38:13 +01:00 |
|
Martin Diehl
|
49de01787d
|
variables not used
|
2020-02-23 16:38:57 +01:00 |
|
Martin Diehl
|
605e976915
|
I don't like loops
use language features and helper functions for shorter code
|
2020-02-23 09:45:19 +01:00 |
|
Martin Diehl
|
7d6c0dc5f4
|
is only needed during initialization
|
2020-02-22 11:42:06 +01:00 |