advise from pylint

python/damask/_result.py

@@ -425,7 +425,7 @@ class Result:
             for pa in path:
                 label = pa.split('/')[2]
 
-                if (pa.split('/')[1] == 'geometry'):
+                if pa.split('/')[1] == 'geometry':
                     dataset = np.array(f[pa])
                     continue
 

python/damask/_rotation.py

@@ -365,8 +365,7 @@ class Rotation:
 
 
     @staticmethod
-    def fromAverage(rotations,
-                    weights = []):
+    def fromAverage(rotations,weights = None):
         """
         Average rotation.
 
@@ -387,7 +386,7 @@ class Rotation:
             raise TypeError("Only instances of Rotation can be averaged.")
 
         N = len(rotations)
-        if weights == [] or not weights:
+        if not weights:
             weights = np.ones(N,dtype='i')
 
         for i,(r,n) in enumerate(zip(rotations,weights)):

python/damask/_table.py

@@ -327,9 +327,9 @@ class Table:
         seen = set()
         labels = []
         for l in [x for x in self.data.columns if not (x in seen or seen.add(x))]:
-            if(self.shapes[l] == (1,)):
+            if self.shapes[l] == (1,):
                 labels.append('{}'.format(l))
-            elif(len(self.shapes[l]) == 1):
+            elif len(self.shapes[l]) == 1:
                 labels += ['{}_{}'.format(i+1,l) \
                           for i in range(self.shapes[l][0])]
             else:

python/damask/_vtk.py

@@ -168,11 +168,11 @@ class VTK:
             Filename for writing.
 
         """
-        if  (isinstance(self.geom,vtk.vtkRectilinearGrid)):
+        if   isinstance(self.geom,vtk.vtkRectilinearGrid):
             writer = vtk.vtkXMLRectilinearGridWriter()
-        elif(isinstance(self.geom,vtk.vtkUnstructuredGrid)):
+        elif isinstance(self.geom,vtk.vtkUnstructuredGrid):
             writer = vtk.vtkXMLUnstructuredGridWriter()
-        elif(isinstance(self.geom,vtk.vtkPolyData)):
+        elif isinstance(self.geom,vtk.vtkPolyData):
             writer = vtk.vtkXMLPolyDataWriter()
 
         default_ext = writer.GetDefaultFileExtension()
@@ -234,17 +234,17 @@ class VTK:
 
         ren = vtk.vtkRenderer()
 
-        renWin = vtk.vtkRenderWindow()
-        renWin.AddRenderer(ren)
+        window = vtk.vtkRenderWindow()
+        window.AddRenderer(ren)
 
         ren.AddActor(actor)
         ren.SetBackground(0.2,0.2,0.2)
 
-        renWin.SetSize(Environment().screen_width,Environment().screen_height)
+        window.SetSize(Environment().screen_width,Environment().screen_height)
 
         iren = vtk.vtkRenderWindowInteractor()
-        iren.SetRenderWindow(renWin)
+        iren.SetRenderWindow(window)
 
         iren.Initialize()
-        renWin.Render()
+        window.Render()
         iren.Start()