Commit Graph

2568 Commits

Author SHA1 Message Date
Martin Diehl 4b791a38a5 no need for a module variable 2020-02-29 17:19:34 +01:00
Martin Diehl 00d6187325 public functions first 2020-02-29 17:04:29 +01:00
Martin Diehl 0c70eefb91 always assume indicators of length 3 2020-02-29 17:03:01 +01:00
Martin Diehl 18ccc49d6f avoid duplicated public/private statements
variables should be private
2020-02-29 15:15:41 +01:00
Martin Diehl 4d227fab2b polishing 2020-02-29 14:34:19 +01:00
Martin Diehl 4935f90d5a polishing 2020-02-29 13:17:33 +01:00
Martin Diehl 2bc36121b2 less public variables, clearer names 2020-02-29 12:57:19 +01:00
Martin Diehl ca76014e45 preparing removal of public functions 2020-02-29 12:21:03 +01:00
Martin Diehl 13e2b0725a useful as external function 2020-02-29 12:20:40 +01:00
Martin Diehl 8700d7784c avoid global variables 2020-02-29 11:10:23 +01:00
Martin Diehl 54881a6ca9 better readable: show that there is no division by zero 2020-02-29 10:55:52 +01:00
Martin Diehl 791db82136 better readable 2020-02-29 10:27:22 +01:00
Martin Diehl 8dd62f1c1e better readable and with sanity checks 2020-02-29 10:20:38 +01:00
Martin Diehl a9572f81a1 bugfix: array access out of bounds
this now uses always the first (source) entry of a particular type.
Needs clearer structure in the future
2020-02-29 09:52:33 +01:00
Martin Diehl 07ab7a4d57 one loop is enough 2020-02-29 09:36:42 +01:00
Martin Diehl 2429eee079 no need for 2 variables 2020-02-29 08:03:06 +01:00
Martin Diehl 0679fa1713 polishing 2020-02-29 07:58:33 +01:00
Martin Diehl ba9bd9120e unifying code style 2020-02-29 07:42:59 +01:00
Martin Diehl 53bd9f9b64 need to read in variable before it is used 2020-02-29 06:39:16 +01:00
Martin Diehl 5350f3950f no need to store temporary variables 2020-02-29 06:38:08 +01:00
Martin Diehl 2b855940f5 not needed here 2020-02-28 21:54:32 +01:00
Martin Diehl e4fe152810 no public parameters 2020-02-28 21:44:40 +01:00
Martin Diehl 3aec4f91f4 WIP: get rid of global variables from lattice 2020-02-28 19:46:18 +01:00
Martin Diehl 0fbba60c91 do not rely on public variables 2020-02-28 19:35:53 +01:00
Martin Diehl 15712d7ebb last remaining outputID enums removed 2020-02-28 11:06:21 +01:00
Martin Diehl 11d456bcd7 no need for enums
no performance difference measurable but less complicated code without
them
2020-02-28 10:58:11 +01:00
Martin Diehl 991d0fe020 polishing/unifying 2020-02-28 10:40:17 +01:00
Martin Diehl cf0f5f0fee polishing 2020-02-28 10:04:38 +01:00
Martin Diehl 4c17963cd6 cleavage systems should reflect lattice symmetry
also {100} cleavage planes need investigation
2020-02-26 19:11:33 +01:00
Martin Diehl c9b9c9103b 2 space indentation 2020-02-26 18:49:20 +01:00
Martin Diehl 73491f3be9 simplified and unified style 2020-02-26 18:37:17 +01:00
Martin Diehl 7e30c10e82 internal functions need no prefix and are located at the end 2020-02-26 18:02:47 +01:00
Martin Diehl 33dc44e512 2 space indentation 2020-02-26 17:55:19 +01:00
Martin Diehl eacf0cc894 does not makes sense to have cleavage planes for isotropic
behavior can be recovered by using 'real' crystal structures and
suitable parameter (easiest for fcc/bcc)
2020-02-26 17:50:29 +01:00
Martin Diehl 1d77af66c0 preparing removal of initializeStructure 2020-02-26 07:23:29 +01:00
Martin Diehl 839443bc85 better (generic) name where possible 2020-02-26 07:06:25 +01:00
Martin Diehl 48604292e2 Merge remote-tracking branch 'origin/development' into MiscImprovements 2020-02-25 17:33:39 +01:00
Martin Diehl 4889e75e52 clearer structure 2020-02-25 17:32:49 +01:00
Sharan Roongta a2e8e5b13b Merge branch 'simple-output-handling' into development 2020-02-23 19:38:13 +01:00
Martin Diehl 49de01787d variables not used 2020-02-23 16:38:57 +01:00
Martin Diehl 605e976915 I don't like loops
use language features and helper functions for shorter code
2020-02-23 09:45:19 +01:00
Martin Diehl 7d6c0dc5f4 is only needed during initialization 2020-02-22 11:42:06 +01:00
Martin Diehl 2cf89b1fdd bugfix: output dataset was too large in case of Ngrains>1
material_phaseAt is defined per constituent/grain/component => no need
to multiply with homogenization_maxNgrains
2020-02-22 11:28:03 +01:00
Martin Diehl bedcd0ad8c sanity check for homogenization
number of (constituent) per microstructure need to match Nconstituents
 in homogenization.
2020-02-22 11:14:11 +01:00
Martin Diehl 62898a70a0 use automated LHS allocation 2020-02-21 23:40:29 +01:00
Martin Diehl f72b856a18 no reason for critical
will always (and only) set to .true.
2020-02-21 23:37:35 +01:00
Martin Diehl 402c282e68 better names
backport form dadf5-usability
2020-02-21 13:27:41 +01:00
Martin Diehl 6a90796618 bugfix: wrong string for comparison 2020-02-21 09:42:56 +01:00
Martin Diehl a2e710c89c alinged for better readability 2020-02-21 08:45:11 +01:00
Martin Diehl c9c78aa90d do not store invFp and invFi for all points
requires to explicitly calculate inverse of Fp and Fi for the tangent
calculation. Hence, classical tradeoff between memory consumption and
runtime.
2020-02-21 08:41:08 +01:00