diff --git a/python/damask/_result.py b/python/damask/_result.py index 820e5d09f..2bd832aad 100644 --- a/python/damask/_result.py +++ b/python/damask/_result.py @@ -4,7 +4,6 @@ import fnmatch import os import copy import datetime -import warnings import xml.etree.ElementTree as ET # noqa import xml.dom.minidom from pathlib import Path @@ -28,12 +27,7 @@ h5py3 = h5py.__version__[0] == '3' chunk_size = 1024**2//8 # for compression in HDF5 -def _view_transition(what,datasets,increments,times,phases,homogenizations,fields): - if (datasets is not None and what is None) or (what is not None and datasets is None): - raise ValueError('"what" and "datasets" need to be used as a pair') - if datasets is not None or what is not None: - warnings.warn('arguments "what" and "datasets" will be removed in DAMASK v3.0.0-alpha7', DeprecationWarning,2) - return what,datasets +def _view_transition(increments,times,phases,homogenizations,fields): if sum(1 for _ in filter(None.__ne__, [increments,times,phases,homogenizations,fields])) > 1: raise ValueError('only one out of "increments", "times", "phases", "homogenizations", and "fields" can be used') else: @@ -213,14 +207,12 @@ class Result: choice = list(datasets).copy() if hasattr(datasets,'__iter__') and not isinstance(datasets,str) else \ [datasets] - what_ = what if what.endswith('s') else what+'s' - - if what_ == 'increments': + if what == 'increments': choice = [c if isinstance(c,str) and c.startswith('increment_') else self.increments[c] if isinstance(c,int) and c<0 else f'increment_{c}' for c in choice] - elif what_ == 'times': - what_ = 'increments' + elif what == 'times': + what = 'increments' if choice == ['*']: choice = self.increments else: @@ -234,18 +226,18 @@ class Result: elif np.isclose(c,self.times[idx+1]): choice.append(self.increments[idx+1]) - valid = _match(choice,getattr(self,what_)) - existing = set(self.visible[what_]) + valid = _match(choice,getattr(self,what)) + existing = set(self.visible[what]) dup = self.copy() if action == 'set': - dup.visible[what_] = sorted(set(valid), key=util.natural_sort) + dup.visible[what] = sorted(set(valid), key=util.natural_sort) elif action == 'add': add = existing.union(valid) - dup.visible[what_] = sorted(add, key=util.natural_sort) + dup.visible[what] = sorted(add, key=util.natural_sort) elif action == 'del': diff = existing.difference(valid) - dup.visible[what_] = sorted(diff, key=util.natural_sort) + dup.visible[what] = sorted(diff, key=util.natural_sort) return dup @@ -298,7 +290,7 @@ class Result: return selected - def view(self,what=None,datasets=None,*, + def view(self,*, increments=None, times=None, phases=None, @@ -313,11 +305,6 @@ class Result: Parameters ---------- - what : {'increments', 'times', 'phases', 'homogenizations', 'fields'} - Attribute to change. DEPRECATED. - datasets : (list of) int (for increments), (list of) float (for times), (list of) str, or bool - Name of datasets; supports '?' and '*' wildcards. DEPRECATED. - True is equivalent to '*', False is equivalent to []. increments: (list of) int, (list of) str, or bool, optional. Number(s) of increments to select. times: (list of) float, (list of) str, or bool, optional. @@ -351,24 +338,24 @@ class Result: >>> r_t10to40 = r.view(times=r.times_in_range(10.0,40.0)) """ - v = _view_transition(what,datasets,increments,times,phases,homogenizations,fields) + v = _view_transition(increments,times,phases,homogenizations,fields) if protected is not None: if v is None: dup = self.copy() else: - what_,datasets_ = v - dup = self._manage_view('set',what_,datasets_) + what,datasets = v + dup = self._manage_view('set',what,datasets) if not protected: print(util.warn('Warning: Modification of existing datasets allowed!')) dup._protected = protected else: - what_,datasets_ = v - dup = self._manage_view('set',what_,datasets_) + what,datasets = v + dup = self._manage_view('set',what,datasets) return dup - def view_more(self,what=None,datasets=None,*, + def view_more(self,*, increments=None, times=None, phases=None, @@ -382,11 +369,6 @@ class Result: Parameters ---------- - what : {'increments', 'times', 'phases', 'homogenizations', 'fields'} - Attribute to change. DEPRECATED. - datasets : (list of) int (for increments), (list of) float (for times), (list of) str, or bool - Name of datasets; supports '?' and '*' wildcards. DEPRECATED. - True is equivalent to '*', False is equivalent to []. increments: (list of) int, (list of) str, or bool, optional. Number(s) of increments to select. times: (list of) float, (list of) str, or bool, optional. @@ -413,11 +395,11 @@ class Result: >>> r_first_and_last = r.first.view_more(increments=-1) """ - what_, datasets_ = _view_transition(what,datasets,increments,times,phases,homogenizations,fields) - return self._manage_view('add',what_,datasets_) + what, datasets = _view_transition(increments,times,phases,homogenizations,fields) + return self._manage_view('add',what,datasets) - def view_less(self,what=None,datasets=None,*, + def view_less(self,*, increments=None, times=None, phases=None, @@ -431,11 +413,6 @@ class Result: Parameters ---------- - what : {'increments', 'times', 'phases', 'homogenizations', 'fields'} - Attribute to change. DEPRECATED. - datasets : (list of) int (for increments), (list of) float (for times), (list of) str, or bool - Name of datasets; supports '?' and '*' wildcards. DEPRECATED. - True is equivalent to '*', False is equivalent to []. increments: (list of) int, (list of) str, or bool, optional. Number(s) of increments to select. times: (list of) float, (list of) str, or bool, optional. @@ -461,8 +438,8 @@ class Result: >>> r_deformed = r_all.view_less(increments=0) """ - what_, datasets_ = _view_transition(what,datasets,increments,times,phases,homogenizations,fields) - return self._manage_view('del',what_,datasets_) + what, datasets = _view_transition(increments,times,phases,homogenizations,fields) + return self._manage_view('del',what,datasets) def rename(self,name_src,name_dst): diff --git a/python/tests/test_Result.py b/python/tests/test_Result.py index 18e09513f..9124cff99 100644 --- a/python/tests/test_Result.py +++ b/python/tests/test_Result.py @@ -69,8 +69,8 @@ class TestResult: @pytest.mark.parametrize('what',['increments','times','phases','fields']) # ToDo: discuss homogenizations def test_view_none(self,default,what): - n0 = default.view(what,False) - n1 = default.view(what,[]) + n0 = default.view(**{what:False}) + n1 = default.view(**{what:[]}) label = 'increments' if what == 'times' else what @@ -79,29 +79,25 @@ class TestResult: @pytest.mark.parametrize('what',['increments','times','phases','fields']) # ToDo: discuss homogenizations def test_view_more(self,default,what): - empty = default.view(what,False) + empty = default.view(**{what:False}) - a = empty.view_more(what,'*').get('F') - b = empty.view_more(what,True).get('F') + a = empty.view_more(**{what:'*'}).get('F') + b = empty.view_more(**{what:True}).get('F') assert dict_equal(a,b) @pytest.mark.parametrize('what',['increments','times','phases','fields']) # ToDo: discuss homogenizations def test_view_less(self,default,what): - full = default.view(what,True) + full = default.view(**{what:True}) - n0 = full.view_less(what,'*') - n1 = full.view_less(what,True) + n0 = full.view_less(**{what:'*'}) + n1 = full.view_less(**{what:True}) label = 'increments' if what == 'times' else what assert n0.get('F') is n1.get('F') is None and \ len(n0.visible[label]) == len(n1.visible[label]) == 0 - def test_view_invalid(self,default): - with pytest.raises(AttributeError): - default.view('invalid',True) - def test_add_invalid(self,default): default.add_absolute('xxxx') @@ -469,7 +465,7 @@ class TestResult: def test_get(self,update,request,ref_path,view,output,flatten,prune): result = Result(ref_path/'4grains2x4x3_compressionY.hdf5') for key,value in view.items(): - result = result.view(key,value) + result = result.view(**{key:value}) fname = request.node.name cur = result.get(output,flatten,prune) @@ -494,7 +490,7 @@ class TestResult: def test_place(self,update,request,ref_path,view,output,flatten,prune,constituents): result = Result(ref_path/'4grains2x4x3_compressionY.hdf5') for key,value in view.items(): - result = result.view(key,value) + result = result.view(**{key:value}) fname = request.node.name cur = result.place(output,flatten,prune,constituents)