223031012
/
DAMASK_EICMD
mirror of https://github.com/achalhp/DAMASK_EICMD.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

need to handle special case of Re() = 0 

ensuring that the real part is positive seems to be a good idea on first
sight, but it would be easier to simply acknowledge that qu = -qu
This commit is contained in:
Martin Diehl 2021-01-03 15:50:15 +01:00
parent 80b8693a66
commit 98723cb0ed
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
python/damask/_rotation.py
View File

@ -105,8 +105,10 @@ class Rotation:
Rotation to check for equality. Rotation to check for equality.
""" """
ambiguous = np.isclose(self.quaternion[...,0],0)
return np.prod(self.shape,dtype=int) == np.prod(other.shape,dtype=int) \ return np.prod(self.shape,dtype=int) == np.prod(other.shape,dtype=int) \
and np.allclose(self.quaternion,other.quaternion) and ( np.allclose(self.quaternion,other.quaternion) \
or np.allclose(self.quaternion[ambiguous],-1*other.quaternion[ambiguous]))
@property @property

6
python/tests/test_Rotation.py
View File

@ -786,6 +786,12 @@ class TestRotation:
def test_equal(self): def test_equal(self):
assert Rotation.from_random(rng_seed=1) == Rotation.from_random(rng_seed=1) assert Rotation.from_random(rng_seed=1) == Rotation.from_random(rng_seed=1)
def test_equal_ambiguous(self):
qu = np.random.rand(10,4)
qu[:,0] = 0.
qu/=np.linalg.norm(qu,axis=1,keepdims=True)
assert Rotation(qu) == Rotation(-qu)
def test_inversion(self): def test_inversion(self):
r = Rotation.from_random() r = Rotation.from_random()
assert r == ~~r assert r == ~~r