From 6657e5c4ebbbfa997cbbf6a5a121dbba90abc4b4 Mon Sep 17 00:00:00 2001
From: Martin Diehl <mail@martin-diehl.net>
Date: Sat, 15 Jan 2022 13:22:15 +0100
Subject: [PATCH] testing a few corner cases

behavior for __eq__ is now following python standard, comparing to wrong
class gives False
---
 python/damask/_result.py         | 2 +-
 python/tests/test_Colormap.py    | 1 +
 python/tests/test_Crystal.py     | 3 +++
 python/tests/test_Grid.py        | 1 +
 python/tests/test_Orientation.py | 9 +++++++++
 python/tests/test_Result.py      | 3 +++
 python/tests/test_Rotation.py    | 9 +++++++++
 7 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/python/damask/_result.py b/python/damask/_result.py
index c87b51a89..02d4174c9 100644
--- a/python/damask/_result.py
+++ b/python/damask/_result.py
@@ -981,7 +981,7 @@ class Result:
             t = 'tensor'
             if o is None: o = 'fro'
         else:
-            raise ValueError(f'invalid norm order {ord}')
+            raise ValueError(f'invalid shape of {x["label"]}')
 
         return {
                 'data':  np.linalg.norm(x['data'],ord=o,axis=axis,keepdims=True),
diff --git a/python/tests/test_Colormap.py b/python/tests/test_Colormap.py
index 156907670..2321745aa 100644
--- a/python/tests/test_Colormap.py
+++ b/python/tests/test_Colormap.py
@@ -81,6 +81,7 @@ class TestColormap:
         assert Colormap.from_predefined('strain') == Colormap.from_predefined('strain')
         assert Colormap.from_predefined('strain') != Colormap.from_predefined('stress')
         assert Colormap.from_predefined('strain',N=128) != Colormap.from_predefined('strain',N=64)
+        assert not Colormap.from_predefined('strain',N=128) == 1
 
     @pytest.mark.parametrize('low,high',[((0,0,0),(1,1,1)),
                                          ([0,0,0],[1,1,1])])
diff --git a/python/tests/test_Crystal.py b/python/tests/test_Crystal.py
index 9c6de965d..235ed554a 100644
--- a/python/tests/test_Crystal.py
+++ b/python/tests/test_Crystal.py
@@ -40,6 +40,9 @@ class TestCrystal:
                     alpha=alpha,beta=beta,gamma=gamma)
         assert np.allclose(np.eye(3),np.einsum('ik,jk',c.basis_real,c.basis_reciprocal))
 
+    def test_basis_invalid(self):
+        with pytest.raises(KeyError):
+            Crystal(family='cubic').basis_real
 
     @pytest.mark.parametrize('keyFrame,keyLattice',[('uvw','direction'),('hkl','plane'),])
     @pytest.mark.parametrize('vector',np.array([
diff --git a/python/tests/test_Grid.py b/python/tests/test_Grid.py
index 2b9ca22f4..6dd94f4bb 100644
--- a/python/tests/test_Grid.py
+++ b/python/tests/test_Grid.py
@@ -44,6 +44,7 @@ class TestGrid:
 
     def test_equal(self,default):
         assert default == default
+        assert not default == 42
 
     def test_repr(self,default):
         print(default)
diff --git a/python/tests/test_Orientation.py b/python/tests/test_Orientation.py
index 9f623fc6c..2a32adea4 100644
--- a/python/tests/test_Orientation.py
+++ b/python/tests/test_Orientation.py
@@ -364,6 +364,11 @@ class TestOrientation:
                 table.save(reference)
             assert np.allclose(P,Table.load(reference).get('Schmid'))
 
+    def test_Schmid_invalid(self):
+        with pytest.raises(KeyError):
+            Orientation(lattice='fcc').Schmid()
+
+
 ### vectorization tests ###
 
     @pytest.mark.parametrize('lattice',['hP','cI','cF']) # tI not included yet
@@ -505,3 +510,7 @@ class TestOrientation:
         for loc in np.random.randint(0,blend,(10,len(blend))):
             assert np.allclose(o[tuple(loc[:len(o.shape)])].to_pole(uvw=v[tuple(loc[-len(v.shape[:-1]):])]),
                                o.to_pole(uvw=v)[tuple(loc)])
+
+    def test_mul_invalid(self):
+        with pytest.raises(TypeError):
+            Orientation.from_random(lattice='cF')*np.ones(3)
diff --git a/python/tests/test_Result.py b/python/tests/test_Result.py
index 4fea08eb3..1da56dedf 100644
--- a/python/tests/test_Result.py
+++ b/python/tests/test_Result.py
@@ -102,6 +102,9 @@ class TestResult:
         with pytest.raises(AttributeError):
             default.view('invalid',True)
 
+    def test_add_invalid(self,default):
+        default.add_absolute('xxxx')
+
     def test_add_absolute(self,default):
         default.add_absolute('F_e')
         in_memory = np.abs(default.place('F_e'))
diff --git a/python/tests/test_Rotation.py b/python/tests/test_Rotation.py
index 2d623adf5..a431bc64b 100644
--- a/python/tests/test_Rotation.py
+++ b/python/tests/test_Rotation.py
@@ -792,6 +792,11 @@ class TestRotation:
         R = Rotation.from_random(shape,rng_seed=1)
         assert R == R if shape is None else (R == R).all()
 
+    @pytest.mark.parametrize('shape',[None,5,(4,6)])
+    def test_allclose(self,shape):
+        R = Rotation.from_random(shape,rng_seed=1)
+        assert R.allclose(R)
+
     @pytest.mark.parametrize('shape',[None,5,(4,6)])
     def test_unequal(self,shape):
         R = Rotation.from_random(shape,rng_seed=1)
@@ -1124,3 +1129,7 @@ class TestRotation:
         weights_r = np.histogramdd(Eulers_r,steps,rng)[0].flatten(order='F')/N * np.sum(weights)
 
         assert np.sqrt(((weights_r - weights) ** 2).mean()) < 5
+
+    def test_mul_invalid(self):
+        with pytest.raises(TypeError):
+            Rotation.from_random()*np.ones(3)