using prospector --tool=dodgy --tool=pyflakes -M to find python flaws

processing/post/3Dvisualize.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,re,string,fnmatch,vtk
+import os,sys,re,fnmatch,vtk
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addAPS34IDEstrainCoords.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addCalculation.py

@@ -1,8 +1,8 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,re,sys,string
-import math                                                                                         # flake8: noqa
+import os,re,sys
+import math                                                                                         # noqa
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addCauchy.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addCauchyX.py

@@ -1,9 +1,8 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,re,sys,math,string,h5py
+import os,string,h5py
 import numpy as np
-import damask
 from optparse import OptionParser, Option
 
 # -----------------------------

processing/post/addCompatibilityMismatch.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addCumulative.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addCurl.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addDeformedConfiguration.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addDeterminant.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 from optparse import OptionParser
 import damask
 

processing/post/addDeviator.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 from optparse import OptionParser
 import damask
 

processing/post/addDivergence.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addEhkl.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addEuclideanDistance.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,itertools
+import os,sys,itertools
 import numpy as np
 from scipy import ndimage
 from optparse import OptionParser

processing/post/addGrainID.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python
 
-import os,sys,string,time,copy
+import os,sys,time,copy
 import numpy as np
 import damask
 from optparse import OptionParser

processing/post/addIPFcolor.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addMapped.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 from optparse import OptionParser
 import damask
 

processing/post/addMises.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,math,string
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addNorm.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,math,string
+import os,sys,math
 from optparse import OptionParser
 import damask
 

processing/post/addOrientations.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addPK2.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addPole.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addQuaternions.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,numpy as np
+import os,sys,numpy as np
 from optparse import OptionParser
 import damask
 

processing/post/addSchmidfactors.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,math,string
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addSpectralDecomposition.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addStrainTensors.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/addTable.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 from optparse import OptionParser
 import damask
 

processing/post/averageDown.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 import scipy.ndimage
 from optparse import OptionParser

processing/post/averageTable.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/binXY.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/blowUp.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask
@@ -55,11 +55,16 @@ for name in filenames:
 # ------------------------------------------ read header ------------------------------------------
 
   table.head_read()
+  errors  = []
 
 # ------------------------------------------ sanity checks ----------------------------------------
   
-  if table.label_dimension(options.coords) != 3: errors.append('coordinates {} are not a vector.'.format(options.coords))
-  else: coordCol = table.label_index(options.coords)
+  if table.label_dimension(options.coords) != 3: 
+    damask.util.croak('coordinates {} are not a vector.'.format(options.coords))
+    table.close(dismiss = True)
+    continue
+  else: 
+    coordCol = table.label_index(options.coords)
 
 
 # ------------------------------------------ assemble header --------------------------------------

processing/post/fillTable.py

@@ -1,7 +1,8 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,re,sys,string,fnmatch,math,random
+import os,re,sys
+import math                                                                                         # noqa
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/filterTable.py

@@ -1,7 +1,8 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,re,sys,fnmatch,math,random
+import os,re,sys,fnmatch
+import math                                                                                         # noqa
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/imageData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 from PIL import Image

processing/post/imageDataDeformed.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 from PIL import Image, ImageDraw

processing/post/imageDataRGB.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 from PIL import Image

processing/post/mentat_colorMap.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os, sys, string
+import os,sys
 import damask
 from optparse import OptionParser
 

processing/post/perceptualUniformColorMap.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import string,sys,os
+import sys,os
 import damask
 from optparse import OptionParser
 

processing/post/permuteData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/reLabel.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import damask
 from optparse import OptionParser
 

processing/post/rotateData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,math
+import os,sys,math
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/sortTable.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string
+import os,sys
 import numpy as np
 from optparse import OptionParser
 import damask

processing/post/stddevDown.py

@@ -144,16 +144,12 @@ for file in files:
   
   posOffset = (shift+[0.5,0.5,0.5])*dimension/resolution
   elementSize = dimension/resolution*packing
-  elem = 1
   for c in xrange(downSized[2]):
     for b in xrange(downSized[1]):
       for a in xrange(downSized[0]):
         datavar[a,b,c,locationCol:locationCol+3] = posOffset + [a,b,c]*elementSize
-        datavar[a,b,c,elemCol] = elem
         table.data = datavar[a,b,c,:].tolist()
         table.data_write()                                                  # output processed line
-        elem += 1
-
   
 # ------------------------------------------ output result ---------------------------------------  
 

processing/post/vtk_addData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,string,glob,re
+import os,glob,re
 import damask
 from optparse import OptionParser
 

processing/post/vtk_addPointcloudData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,vtk
+import os,sys,vtk
 import damask
 from optparse import OptionParser
 

processing/post/vtk_addRectilinearGridData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,vtk
+import os,vtk
 import damask
 from collections import defaultdict
 from optparse import OptionParser

processing/post/vtk_addVoxelcloudData.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,vtk
+import os,sys,vtk
 import damask
 from collections import defaultdict
 from optparse import OptionParser

processing/post/vtk_pointcloud.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,vtk
+import os,sys,vtk
 import numpy as np
 import damask
 from optparse import OptionParser

processing/post/vtk_scalars2vectors.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 # -*- coding: UTF-8 no BOM -*-
 
-import os,sys,string,shutil
+import os,sys,shutil
 import damask
 from optparse import OptionParser
 from vtk import *